fix normalization of python_full_version markers with pre-release versions
#893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideReplace manual text padding in nested marker creation with direct dataclass manipulation and rely on version str; make PEP440Version.text init=False to enforce normalization via to_string and remove parser text assignment; update tests to expect the new normalized version texts and adjusted markers. Class diagram for updated PEP440Version and Release handlingclassDiagram
class PEP440Version {
+Release release
+ReleaseTag pre
+ReleaseTag post
+ReleaseTag dev
+LocalSegmentType local
-str text (init=False)
-tuple _compare_key (init=False)
+__post_init__()
+to_string()
+_make_compare_key()
}
class Release {
+int major
+int minor
+int patch
}
PEP440Version --> Release : release
PEP440Version --> ReleaseTag : pre
PEP440Version --> ReleaseTag : post
PEP440Version --> ReleaseTag : dev
PEP440Version --> LocalSegmentType : local
Class diagram for create_nested_marker changesclassDiagram
class create_nested_marker {
+constraint
+version
+min_name
+op
+part
}
class Release {
+major
+minor
+patch
}
class Version {
+release
+stable
+__str__()
}
create_nested_marker --> Version : version
Version --> Release : release
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `tests/constraints/version/test_parse_constraint.py:456` </location>
<code_context>
+ ("^0-alpha.1", ">=0a1,<1"),
+ ("^0.1-alpha.1", ">=0.1a1,<0.2"),
+ ("^0.0.2-alpha.1", ">=0.0.2a1,<0.0.3"),
+ ("^0.1.2-alpha.1", ">=0.1.2a1,<0.2.0"),
("~1", ">=1,<2"),
("~1.0", ">=1.0,<1.1"),
</code_context>
<issue_to_address>
**suggestion (testing):** Missing test for normalization of post-release and dev-release constraints.
Please add tests for normalization of post-release (e.g., "1.0.0-post1") and dev-release (e.g., "1.0.0.dev1") constraints to cover these cases.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
radoering
changed the title
python_full_version markers with pre-release versions
for more information, see https://pre-commit.ci
radoering
approved these changes
Oct 31, 2025
This was referenced Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: python-poetry#10599
Replace the naive textual manipulation in
create_nested_markerwith direct manipulation of the objects, relying on their__str()__implementation to be good.To make sure that the
textfield is recalculated here, I made it aninit=Falsefield. That has the knock-on effect that we always normalize versions - which seems fine to me, probably a good thing.There is one testcase in poetry proper that will need a one-character tweak to expect the newly normalized version number.